Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2377: Throw error when trying to stub non-configurable or non-writable properties #2417

Merged
merged 2 commits into from Dec 24, 2021
Merged

Fix 2377: Throw error when trying to stub non-configurable or non-writable properties #2417

merged 2 commits into from Dec 24, 2021

Conversation

sdotson
Copy link
Contributor

@sdotson sdotson commented Dec 23, 2021 •
edited

Purpose (TL;DR) - mandatory

Fixes issue #2377

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. Check out the tests I created. That would probably be the easiest way to verify

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@sdotson sdotson mentioned this pull request Dec 23, 2021
Closed
fatso83
fatso83 requested changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@fatso83 fatso83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is fine and ready for merge AFAI can see. Just two things:

  • it's "it throws"
  • remove the changes to the package lock file

@sdotson sdotson force-pushed the issue2377-throw-error-for-nonconfigurable-or-non-writable-props branch from 8456d6a to 7bf93e8 Compare December 23, 2021 22:21
@sdotson
Copy link
Contributor Author

sdotson commented Dec 23, 2021

Thank you! This is fine and ready for merge AFAI can see. Just two things:

  • it's "it throws"
  • remove the changes to the package lock file

consider it done! happy to help!

@fatso83 fatso83 added the semver:major changes will cause a new major version label Dec 24, 2021
@fatso83 fatso83 merged commit 12a4593 into sinonjs:master Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatso83 fatso83 fatso83 requested changes

Assignees
No one assigned
Labels
semver:major changes will cause a new major version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sdotson @fatso83