New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sinon 10 breaks Internet Explorer 11 support #2358
Comments
We dropped support for IE11 with version 10: https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md#1000--2021-03-22. Going forwards, we only support evergreen browsers. All prior versions still work, of course, so you are not exactly stuck 😄 |
In that case please update the documentation https://sinonjs.org/releases/latest/ which mentions Internet Explorer 11 as a supported runtime. |
Great catch! That is indeed out of date. @mroderick I don't think we should keep any of that text block. It is woefully out of date and even worse: misleading - we haven't verified Sinon 10 in any of those! Might have been true for Sinon 3 or something :) |
I agree. Let's improve that! |
See #2366 |
(closes #209) I upgraded it as far as v9 by adding core-js-bundle, but will need to replace PhantomJS to go any further. This is likely because v10 is now using template strings which require transpilation. sinonjs/sinon#2358
Describe the bug
Sinon 10 is using Template literal strings (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals) which is not supported by IE11.
To Reproduce
Steps to reproduce the behavior:
Looking at https://sinonjs.org/releases/sinon-10.0.1.js
assert.fail(`${method} is not a function\`);
is used.In 9.x at https://sinonjs.org/releases/sinon-9.2.4.js
assert.fail(method + " is not a function");
is used, which is working with IE11.Expected behavior
Do not use template literals or proper transpiling.
The text was updated successfully, but these errors were encountered: