Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sinon 10 uses fake-timers 7 and nise 5, nise 5 uses fake-timers 6. So with one package we get two defferent majors of subpackage. #2353

Closed
blazkovicz opened this issue Apr 9, 2021 · 5 comments
Closed

Sinon 10 uses fake-timers 7 and nise 5, nise 5 uses fake-timers 6. So with one package we get two defferent majors of subpackage. #2353

blazkovicz opened this issue Apr 9, 2021 · 5 comments

Comments

@blazkovicz
Copy link

Sinon 10 uses fake-timers 7 and nise 5, nise 5 uses fake-timers 6. So with one package we get two defferent majors of subpackage.
Fix please!
bcoe added a commit to bcoe/DefinitelyTyped that referenced this issue Apr 9, 2021
@bcoe
fix(sinon): use sinonjs__fake-timers rather than alias
51905f4 
https://github.com/sinonjs/fake-timers appears to have added types which are incompatible
with the current implementation in DefinitelyTyped.

Refs: sinonjs/sinon#2353
Refs: sinonjs/sinon#2352
@bcoe bcoe mentioned this issue Apr 9, 2021
Closed
7 tasks
@bcoe
Copy link

bcoe commented Apr 11, 2021

For clarification, @mroderick. The issue reported by myself and @nicoleczhu is actually related to this (not #2352, as first thought). Although both issues are related to timers changes.

@43081j is working on a change here to get types corrected DefinitelyTyped/DefinitelyTyped#52297

@mroderick mroderick mentioned this issue Apr 11, 2021
Merged
@mroderick
Copy link
Member

nise@5.0.2 uses @sionjs/fake-timers@7

If you re-install sinon@10, you should only get one version of @sinonjs/fake-timers: v7.0.4

@mroderick mroderick mentioned this issue Apr 11, 2021
Closed
@fatso83
Copy link
Contributor

fatso83 commented Apr 12, 2021

I guess this can be closed. Can @blazkovicz confirm that this indeed fixes the issue?

@fatso83 fatso83 closed this as completed Apr 20, 2021
@fatso83 fatso83 reopened this Apr 20, 2021
@blazkovicz
Copy link
Author

blazkovicz commented Apr 20, 2021 •
edited

I resolved nise to 5.0.2 version in yarn, that solved the issue, thanks!

@fatso83 fatso83 closed this as completed Apr 20, 2021
@mroderick
Copy link
Member

@blazkovicz thank you for the error report 🥇 and the followup 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mroderick @bcoe @fatso83 @blazkovicz