Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code for the Promise fake throws on IE11 #2316

Closed
muodov opened this issue Dec 2, 2020 · 3 comments · Fixed by #2317
Closed

Code for the Promise fake throws on IE11 #2316

muodov opened this issue Dec 2, 2020 · 3 comments · Fixed by #2317
Labels

Comments

@muodov
Copy link
Contributor

muodov commented Dec 2, 2020

Describe the bug
After the recent change, IE11 throws an exception (Promise is not defined) in this line

To Reproduce
Steps to reproduce the behavior:

  1. User karma with karma-sinon
  2. Run any test with sinon, and see error

Expected behavior
it should gracefully ignore that code piece if Promise is not defined in self.

Context (please complete the following information):

  • Library version: 9.0.9
  • Other libraries you are using: karma, karma-sinon

Additional context
I know. IE11 is not exactly a modern browser, but some companies like ours have to support them for their clients. And it sounds like the fix in sinon will be tiny

@mantoni
Copy link
Member

mantoni commented Dec 3, 2020

I agree. The tests are already checking for promise support and the code should do that as well.

@muodov Would you care to provide a patch?

@mantoni mantoni added the Bug label Dec 3, 2020
@muodov
Copy link
Contributor Author

muodov commented Dec 3, 2020

@mantoni sure. It's quite a busy time in my life, so give me a couple of weeks, Ill try to get to it.
If someone else needs this fix sooner, feel free to do it without waiting for me.

@muodov
Copy link
Contributor Author

muodov commented Dec 7, 2020

@mantoni I've created a tiny PR with a fix. Would you mind to take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants