Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting a method argument for sandbox.replaceGetter in site documentation #2314

Merged
merged 1 commit into from Nov 27, 2020
Merged

Correcting a method argument for sandbox.replaceGetter in site documentation #2314

merged 1 commit into from Nov 27, 2020

Conversation

ikiviki
Copy link
Contributor

@ikiviki ikiviki commented Nov 27, 2020 •
edited

Purpose (TL;DR) - mandatory

Correcting an improper method call for sandbox.replaceGetter in site documentation.

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm test

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@fatso83 fatso83 merged commit 895a50d into sinonjs:master Nov 27, 2020
@fatso83
Copy link
Contributor

fatso83 commented Nov 27, 2020

thanks!

@ikiviki ikiviki deleted the patch-1 branch November 27, 2020 09:56
@ikiviki
Copy link
Contributor Author

ikiviki commented Nov 27, 2020

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatso83 fatso83 fatso83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ikiviki @fatso83