Make sandboxes each use their own assert object #2302
Merged
+209
−181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatso83
requested changes
Oct 12, 2020
| @@ -37,6 +37,8 @@ function Sandbox() { | |||
| var fakeRestorers = []; | |||
| var promiseLib; | |||
|
|
|||
| sandbox.assert = sinonAssert.createAssertObject(); | |||
fatso83
reviewed
Oct 13, 2020
|
Thanks for the changes: a very welcome improvement, Kim! 💯 Just a tip: if you think the diff is messier than what is actually happening, you can suppress all whitespace changes by passing a query parameter: |
|
Ok, so no |
|
Very nice PR, thank you 🍰 |
|
This has been published with |
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Fix issue #2298 by having assertion objects be created by each sandbox instead of using the global one
Intuitively you would think that sandboxes use isolated assertion objects. But this was not the case. If you overrode the
failExceptionorpass/failfunctions, they would apply to all sandboxes and all assertions. This particularly was an issue with concurrent testing, such as with AVA.We no longer create and export a single
assertobject, instead there is acreateAssertionObjectfunction that is used inside the sandboxes' constructor.How to verify - mandatory
npm installnpm testChecklist for author
npm run lintpassesPS: on github the diff shows very poorly. In actuality only ~3 lines changed and a test case was added, but a buch of lines were indented one step.