Add usingPromise() method on fakes to fix issue #2293 #2301
Conversation
lib/sinon/fake.js
Outdated
| throw new TypeError("Expected f argument to be a Function"); | ||
| } | ||
| function fakeClass() { | ||
| var promiseLib; |
There was a problem hiding this comment.
If they always have the same interface, why bother with branching?
| var promiseLib; | |
| var promiseLib = Promise; |
lib/sinon/fake.js
Outdated
| if (promiseLib) { | ||
| return promiseLib.resolve(value); | ||
| } |
There was a problem hiding this comment.
| if (promiseLib) { | |
| return promiseLib.resolve(value); | |
| } |
lib/sinon/fake.js
Outdated
| if (promiseLib) { | ||
| return promiseLib.reject(value); | ||
| } |
There was a problem hiding this comment.
| if (promiseLib) { | |
| return promiseLib.reject(value); | |
| } |
There was a problem hiding this comment.
Hi @fatso83,
That actually makes a whole lot of sense, will take those edits. Thanks!
There was a problem hiding this comment.
Also noticed that i'm not wrapping the the rejected object as an Error. Will correct that as well.
…required code branching
|
This is great, thanks a lot, @romanbalayan! |
|
Hi @fatso83, I'm also currently participating in the hacktoberfest event organized by Digital Ocean, hopefully it would not be much of a bother for you to add the hacktoberfest-accepted label to this PR so it may be counted towards my progress? Thank you! |
|
Done! |
|
Great PR! Thank you @romanbalayan |
|
This has been published with |
Add usingPromise() method on fakes
Fix issue #2293. Added implementation of usingPromise() to be able to override global Promise library.
How to verify - mandatory
npm installChecklist for author
npm run lintpasses