Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node 8 support #2210

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Drop Node 8 support #2210

merged 2 commits into from
Feb 18, 2020

Conversation

mroderick
Copy link
Member

As can be seen at https://github.com/nodejs/Release, Node 8 reached
"end" of life on 2019-12-31, and is no longer actively supported.

We will stop testing in Node 8 and start testing in Node 13, which will
become the next LTS release from April 2020.

How to verify

  1. Observe that we're no longer testing in Node 8
  2. Observe that we've started testing in Node 13

As can be seen at https://github.com/nodejs/Release, Node 8 reached
"end" of life on 2019-12-31, and is no longer actively supported.

We will stop testing in Node 8 and start testing in Node 13, which will
become the next LTS release from April 2020.
@mroderick mroderick added the semver:major changes will cause a new major version label Feb 1, 2020
@mshaaban0
Copy link

LGTM 👍

Copy link
Member

@mantoni mantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fatso83 fatso83 merged commit 3a5e5c7 into sinonjs:master Feb 18, 2020
@mroderick mroderick deleted the drop-node-8 branch February 19, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:major changes will cause a new major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants