Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

No release notes for 7.4.0 #2071

Closed
ffflorian opened this issue Aug 5, 2019 · 7 comments
Closed

No release notes for 7.4.0 #2071

ffflorian opened this issue Aug 5, 2019 · 7 comments

Comments

@ffflorian
Copy link

Hi,
I don't know how this usually works with sinon releases but I was wondering why the latest release 7.4.0 doesn't have a release tag and no release notes. Is there a reason for this or am I just being too impatient? 馃槂

@fatso83
Copy link
Contributor

fatso83 commented Aug 5, 2019

I might have forgot to git push --tags after doing npm publish ...

@hieuunguyeen
Copy link

+1
Does 7.4.x have changes regarding createStubInstance? It's breaking our tests that were passing with 7.3.2

@fatso83
Copy link
Contributor

fatso83 commented Aug 5, 2019

I'll try to revert @latest to 7.3.2, seeing that the release commits weren't pushed.

@fatso83
Copy link
Contributor

fatso83 commented Aug 5, 2019

So 7.4.0 has been unpublished and 7.3.2 set as latest. But I might need to ping you again, @hieuunguyeen, as there were no intended breaking changes. The only reason for a version change, AFAIK, was that I bumped the Lolex and Nise version numbers, which added some API's.

Could you try to install the latest Sinon version from master by doing npm install sinonjs/sinon and try to run your tests using that? If they break, could you open a new issue with a reproducible test case?

@fatso83 fatso83 closed this as completed Aug 5, 2019
@simoneb
Copy link

simoneb commented Aug 5, 2019

Not a good move to unpublish a version. You may know that there are lots of automated tools out there updating dependencies automatically. By unpublishing 7.4.0 you have broken our CI pipeline and probably quite a few others.

UPDATE: to make this comment a little more constructive, I would suggest that you deprecate the version next time and publish a new version, so people can roll forward rather than roll back.

@gajus
Copy link

gajus commented Aug 5, 2019

@fatso83 Can you please release version 7.4.0? Even if it is just re-releasing the current version. This broke our CI/CD pipeline for hundreds of packages.

@fatso83
Copy link
Contributor

fatso83 commented Aug 6, 2019

Sorry about this noise. A bit rusty on the NPM intricasies. 7.4.1 has been released to remedy the situation.

@gajus It's not possible to reuse a version that has been unpublished, so 7.4.0 will stay gone.

@sinonjs sinonjs locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants