Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration guide from 6 -> 7? #2061

Closed
toymachiner62 opened this issue Jul 18, 2019 · 5 comments
Closed

Migration guide from 6 -> 7? #2061

toymachiner62 opened this issue Jul 18, 2019 · 5 comments

Comments

@toymachiner62
Copy link

Describe the bug
Is there a migration guide to go from sinon version 6 -> 7? I see there are guides for all other versions. https://sinonjs.org/releases/v7.3.2/

Screenshots
If applicable, add screenshots to help explain your problem.
image

@fatso83
Copy link
Contributor

fatso83 commented Jul 19, 2019

Ah, well spotted. I checkd the semver:major and it seems #1926 (lolex upgrade) was the reason. Since Lolex 3 had a breaking API change (negative timers no longer possible), this validated a major release for Sinon as well.

You could also see it from the Changelog.

Would you like to create the migration guide and supply a PR? It's basically a one-liner, it seems :-)

@Zaky7
Copy link
Contributor

Zaky7 commented Aug 8, 2019

Hi, I can help in this. if someone point me in right Direction. After googling I came to know after upgrading the lolex in sinon, we cannot use negative timers. So we need to avoid that. So how can I help you with the migration guide from sinon6 to sinon7 . Anything else I am missing. Or anyone else is creating a migration guide?. Please provide the link

@fatso83
Copy link
Contributor

fatso83 commented Aug 8, 2019

@Zaky7 Please do, that would be great!

Add a file like the others here: https://github.com/sinonjs/sinon/tree/master/docs/guides
Contributing to docs: https://github.com/sinonjs/sinon/blob/master/docs/CONTRIBUTING.md

@Zaky7
Copy link
Contributor

Zaky7 commented Aug 9, 2019

I have created PR please Review.. Thanks

@mroderick
Copy link
Member

This has been resolved with #2074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants