Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we implement automated releases? #1657

Open
mroderick opened this issue Jan 16, 2018 · 2 comments
Open

Should we implement automated releases? #1657

mroderick opened this issue Jan 16, 2018 · 2 comments

Comments

@mroderick
Copy link
Member

#1656 was caused by me overlooking a manual step when preparing the release.

This has likely happened before, and will likely happen again.

I think we should consider implementing automated releases of some sort.

Ideas

@mroderick mroderick changed the title Implement automated releases Should we implement automated releases? Jan 16, 2018
@lucasfcosta
Copy link
Member

Hello @mroderick,

As I want to step back-in now that I've got time to contribute again, here's my 2 cents on this matter.

We've been using semantic-release in chai for quite a while, which has been very helpful especially considering the number of different packages that we maintain which form the main library.

That might not be the case here, but manual releases are still error-prone and time-consuming. If I recall correctly, Chai once broke AirBnB's internal build because of a breaking change released under a non-major bump.

Since in this repo also contains the documentation for sinon I don't think keeping the docs in sync would be a problem.

I'd be happy to have a try at this if everyone thinks it's worth it.

@mroderick
Copy link
Member Author

Hello @mroderick,

As I want to step back-in now that I've got time to contribute again, here's my 2 cents on this matter.

We've been using semantic-release in chai for quite a while, which has been very helpful especially considering the number of different packages that we maintain which form the main library.

That might not be the case here, but manual releases are still error-prone and time-consuming. If I recall correctly, Chai once broke AirBnB's internal build because of a breaking change released under a non-major bump.

Since in this repo also contains the documentation for sinon I don't think keeping the docs in sync would be a problem.

I'd be happy to have a try at this if everyone thinks it's worth it.

That would be great! If it would be easier, feel free to try it out on one of the smaller libraries like @sinonjs/samsam, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants