From 3c0dc46e671ca23eaf86c0dfdfa55598aba42f34 Mon Sep 17 00:00:00 2001
From: Maximilian Antoni <mail@maxantoni.de>
Date: Fri, 7 May 2021 10:47:03 +0200
Subject: [PATCH] Reduce indentation by checking for error conditions first

Co-authored-by: Morgan Roderick <20321+mroderick@users.noreply.github.com>
---
 lib/sinon/promise.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/sinon/promise.js b/lib/sinon/promise.js
index e9c446c96..eaf7a2010 100644
--- a/lib/sinon/promise.js
+++ b/lib/sinon/promise.js
@@ -56,12 +56,12 @@ function promise(executor) {
      * @param {Function} callback
      */
     function finalize(status, value, callback) {
-        if (sinonPromise.status === STATUS_PENDING) {
-            sinonPromise.status = status;
-            callback(value);
-            return;
+        if (sinonPromise.status !== STATUS_PENDING) {
+            throw new Error(`Promise already ${sinonPromise.status}`);
         }
-        throw new Error(`Promise already ${sinonPromise.status}`);
+
+        sinonPromise.status = status;
+        callback(value);
     }
 
     sinonPromise.resolve = function (value) {