Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hasRef #419

Merged
merged 4 commits into from Feb 3, 2022
Merged

add hasRef #419

merged 4 commits into from Feb 3, 2022

Conversation

soferdani
Copy link
Contributor

Purpose (TL;DR) - mandatory

add refed attribute to the res object


add this as required in the issue - Missing hasRef for Node #408

Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@SimenB
Copy link
Member

SimenB commented Jan 31, 2022

Tests? 😀

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #419 (45c414a) into master (87fd84e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   95.46%   95.49%   +0.02%     
==========================================
  Files           1        1              
  Lines         618      621       +3     
==========================================
+ Hits          590      593       +3     
  Misses         28       28              
Flag Coverage Δ
unit 95.49% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fake-timers-src.js 95.49% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87fd84e...45c414a. Read the comment docs.

@fatso83
Copy link
Contributor

fatso83 commented Jan 31, 2022

Yeah, realize we are talking about a handful of lines here, but a little test to demonstrate use would be nice

@soferdani
Copy link
Contributor Author

Sorry for the delay, I added the tests as you asked (I hope..) Please let me know if you think I need to add/remove something.

@fatso83
Copy link
Contributor

fatso83 commented Feb 3, 2022

This failed due to not running Prettier (which I fixed for you), but the tests fail as well in Chromium, since there is no conditional checking here.

@mroderick
Copy link
Member

This has been published to the npm registry as 9.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants