fix: handle missing stack when throwing recursion errors #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Sep 21, 2021
| @@ -109,6 +109,7 @@ const globalObject = require("@sinonjs/commons").global; | |||
| * @property {number} createdAt | |||
| * @property {boolean} immediate | |||
| * @property {number} id | |||
| * @property {Error} [error] | |||
There was a problem hiding this comment.
I think this is how you say optional?
benjamingr
reviewed
Sep 22, 2021
benjamingr
approved these changes
Sep 22, 2021
|
I think this, release, then figure out what to do in #398 (I'm not totally happy with it) |
|
I'll rebase both to trigger CI 🙂 |
SimenB
force-pushed
the
missing-recursion-error
branch
from
f960f35
to
e4d9c9c
Compare
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
==========================================
+ Coverage 93.85% 93.87% +0.02%
==========================================
Files 1 1
Lines 586 588 +2
==========================================
+ Hits 550 552 +2
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #398 which I think we should land and release as 8.0.1. Guards against the error and falls back to the behavior of v7