Issue 390 implicit dependencies on faking interval #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
==========================================
+ Coverage 93.84% 93.85% +0.01%
==========================================
Files 1 1
Lines 585 586 +1
==========================================
+ Hits 549 550 +1
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fatso83
force-pushed
the
issue-390-implicit-dependencies-on-faking-interval
branch
from
dfc764e
to
31b1127
Compare
|
Not heard anything. Merging. |
fatso83
referenced
this pull request
Jun 21, 2021
#102) lolex can now attach itself to the system timers and automatically advance mocked time at a certain 'real' interval - changed uninstall signature to carry over configuration flags in cases where this might be necessary - updated shouldAdvanceTime functionality to support new install method signature - moved time delta parameter to config * Updated Readme.md and History.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Remove implicit dependency on
*Intervalfunctions in the shouldAdvanceTime feature.Background (Problem in detail) - optional
See #390