New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google storage push is broken #252
Comments
Yes pinning the version to what previously worked is a good bet for now. I’d be happy to review a PR for this. |
See singularityhub/sregistry-cli#252, and links therein
Temporary fix for singularityhub#252. Definitive fix will need to be implemented in google-api-client.
Fixed with #253 |
See singularityhub/sregistry-cli#252, and links therein
This is fixed upstream now, may be useful to change pinning here, and revert the corresponding PR. |
@tschoonj that's a good idea - revert would remove all the commits done for that PR (which I don't think we want to do) but if you have bandwidth in the next few weeks, do you want to open a simple PR to bump the version and change pinning? We could then update the conda force recipe to match. |
First thing tomorrow morning! |
Woot! Thanks @tschoonj ! |
Describe the bug
Trying to upload an image to a google storage bucket does not work with httplib2 >= 0.16.0 due to changes introduced in that version that are currently not handled by the google-api-client-api library.
What currently happens is a 'hanging' upload due to an exception being thrown:
which is caught by the retry call, so had to remove the decorator to actually get this far 😄
To Reproduce
Steps to reproduce the behavior: install sregistry with google-storage backend support using the latest versions of all required dependencies.
This may also affect other (google-) backends but I haven't tested this.
Version of Singularity and Singularity Registry Client
sregistry-client: 0.2.33
Anything else?
Should we pin the version of httplib2 in the conda repo to <= 0.15.0 until the google-api-client library contains a fix?
The text was updated successfully, but these errors were encountered: