New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore invalid comments #51

Open

sindresorhus opened this issue Nov 24, 2021 · 0 comments

Labels

bug help wanted

Owner

sindresorhus commented Nov 24, 2021 •

edited

For example, [] */ should be ignored.

strip-json-comments/test.js

Lines 67 to 70 in ad70a18

    
           test.failing('handles malformed block comments', t => { 
        
           	t.is(stripJsonComments('[] */'), '[] */'); 
        
           	t.is(stripJsonComments('[] /*'), '[] /*'); // Fails 
        
           });

The text was updated successfully, but these errors were encountered:

sindresorhus added bug help wanted labels

sindresorhus added a commit that referenced this issue


          Add failing test for #51

ad70a18

sindresorhus mentioned this issue

Switch to a string.replace approach #50

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment