Handle streams attached to an error by replacing them with '[object Stream]'

[wodka]

fixes #56

[Richienb]

If the module is going to handle readables, then what about writables and transform streams?

[Richienb]

Also, this can be used: https://github.com/sindresorhus/is-stream

[wodka]

Also, this can be used: https://github.com/sindresorhus/is-stream

would make sense - what do you think about adding this as a dependency?

[sindresorhus]

This needs a test.

[sindresorhus]

would make sense - what do you think about adding this as a dependency?

Nah. I think what you have is fine for now. https://github.com/sindresorhus/serialize-error/pull/57/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R80

[sindresorhus]

This also needs to support https://nodejs.org/api/webstreams.html#class-readablestream (web streams)

[fregante]

Same applies here: #55 (comment)

I didn't realize that serialize-error already includes Buffer accommodations. Even that one seems unrelated.

[wodka]

update: working on the tests

[sindresorhus]

I didn't realize that serialize-error already includes Buffer accommodations. Even that one seems unrelated.

It's just to make the common use-case nicer. It's not meant for two-way transfer. It's mostly just to make it nicer for logging and storing errors.

[wodka]

@sindresorhus would you think it makes more sense to split it up to show a text depending on the stream type? Something along the lines of this:

		if (typeof value === 'object' && typeof value.pipe === 'function') {
			const writeable = typeof value._write === 'function' && typeof value._writableState === 'object';
			const readable = typeof value._read === 'function' && typeof value._readableState === 'object';

			if (writeable && readable && typeof value._transform === 'function') {
				to[key] = '[object TransformStream]';
				continue;
			}

			if (writeable && readable) {
				to[key] = '[object DuplexStream]';
				continue;
			}

			if (readable) {
				to[key] = '[object ReadableStream]';
				continue;
			}

			if (writeable) {
				to[key] = '[object WriteableStream]';
				continue;
			}

			to[key] = '[object Stream]';
			continue;
		}

[sindresorhus]

would you think it makes more sense to split it up to show a text depending on the stream type? Something along the lines of this:

No, let's keep it simple.

[wodka]

ok, then I think it's done