Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pMapSkip #39

Merged
merged 9 commits into from Jun 28, 2021
Merged

Add pMapSkip #39

merged 9 commits into from Jun 28, 2021

Conversation

Richienb
Copy link
Contributor

Fixes #38

@Richienb
Add .skip
9552412 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
papb
papb reviewed Jun 26, 2021
View reviewed changes
index.d.ts Show resolved Hide resolved
@Richienb
Demonstrate skipping in example
90e40cf 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@sindresorhus
Copy link
Owner

I'm not sold on calling it just skip when it's a named export. Either a more verbose name or put it on pMap. I think I would prefer the former.

@Richienb
Copy link
Contributor Author

I'm not sold on calling it just skip when it's a named export. Either a more verbose name or put it on pMap. I think I would prefer the former.

Maybe pMapSkip?

sindresorhus
sindresorhus reviewed Jun 27, 2021
View reviewed changes
readme.md Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Maybe pMapSkip?

Yeah, I cannot think of anything better.

@Richienb Richienb changed the title Add .skip Add pMapSkip Jun 27, 2021
@Richienb
Rename skip to pMapSkip
1b985f2 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
sindresorhus
sindresorhus reviewed Jun 28, 2021
View reviewed changes
readme.md Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

Richienb and others added 3 commits June 28, 2021 20:09
@Richienb @sindresorhus
Update readme.md
482e218 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@Richienb
Update index.d.ts
7767b2b
@Richienb
Merge branch 'main' into add-skip
7e24fdb
@sindresorhus sindresorhus merged commit c9c0882 into sindresorhus:main Jun 28, 2021
@Richienb
Copy link
Contributor Author

@sindresorhus Could you release this for now?

@sindresorhus
Copy link
Owner

https://github.com/sindresorhus/p-map/releases/tag/v5.1.0

@Thore1954 Thore1954 mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papb papb papb left review comments

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow leaving an empty value
3 participants
@Richienb @sindresorhus @papb