Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: spinner.info([text]) #39

Closed
ghost opened this issue Mar 24, 2017 · 3 comments
Closed

Request: spinner.info([text]) #39

ghost opened this issue Mar 24, 2017 · 3 comments

Comments

@ghost
Copy link

ghost commented Mar 24, 2017

Right now there's spinner.succeed([text]) and spinner.fail([text]) where the idea is that it's either a success or a failure e.g. due to an error. I'd like a spinner.info([text]), which ends as something like a yellow !.

I want this because it isn't always the case that a function just succeeds or fail, sometimes you can have e.g. a harmless error that when reached you should be made aware of that it's reached but it hasn't succeeded or failed.

So spinner.fail would be for "bad" errors, spinner.info would be for "harmless" errors, and spinner.succeed would be for entirely successful runs.

Thoughts?

@ghost
Copy link
Author

ghost commented Mar 24, 2017

Just checked the source code and found that you already have spinner.warn, but that it just isn't available yet in NPM. Would you mind updating the npm version with this function? Would be great!

@sindresorhus
Copy link
Owner

Done

@ghost
Copy link
Author

ghost commented Mar 24, 2017

Awesome! Can I donate a coffee somewhere? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant