Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence Jest warning when Ora is required in a test #150

Merged
merged 1 commit into from Jul 17, 2020
Merged

Silence Jest warning when Ora is required in a test #150

merged 1 commit into from Jul 17, 2020

Conversation

Scrabouillmax
Copy link
Contributor

Fixes #149

Applying this change on the minimal reproduction fixes the leak:

Screenshot 2020-07-16 at 15 41 54

sroze
sroze approved these changes Jul 17, 2020
View reviewed changes
Copy link

@sroze sroze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Scrabouillmax 👍

@sindresorhus sindresorhus changed the title Fix memory leak when ora is required during tests Silence Jest warning when Ora is required in a test Jul 17, 2020
@sindresorhus
Copy link
Owner

I'm ok with landing this, but it's not a memory leak. EventEmitter is notorious for false-positives warnings.

@sindresorhus sindresorhus merged commit 594865f into sindresorhus:master Jul 17, 2020
This was referenced Mar 12, 2021
Merged
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sroze sroze sroze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak when ora is required during tests.
3 participants
@Scrabouillmax @sindresorhus @sroze