-
-
Notifications
You must be signed in to change notification settings - Fork 254
Add openApp
method
#263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openApp
method
#263
Conversation
openApp
method
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
thanks @sindresorhus. these review comments are neat and i should update all. please take a look when you get a chance. |
|
||
Type: `Array<string>` | ||
Default: `[]` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the description from index.d.ts
Can you manually verify that these changes do not break normal usage of |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
thanks for kindly helping with these wordings.
i did execute |
Lines 4 to 7 in e21e623
|
i did go through the test cases one by one in macos. there are just two cases with pipe not opening anything. that's same with main branch and Lines 57 to 63 in e21e623
|
thank you, @sindresorhus. you are awesome to have these cool libraries. |
open
is good to facilitate cross platform opening. sometimes i just want to open an application without specifying url or file target. the concept is something likeopen(null, { app: { name: open.apps.chrome }});
. this pr just introduces anopenApp
api. please help to review if the concept makes sense.