WSL: Ignore commented mount point lines in wsl.conf #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
May 5, 2021
| @@ -42,7 +42,7 @@ const getWslDrivesMountPoint = (() => { | |||
| } | |||
|
|
|||
| const configContent = await fs.readFile(configFilePath, {encoding: 'utf8'}); | |||
| const configMountPoint = /root\s*=\s*(?<mountPoint>.*)/g.exec(configContent); | |||
| const configMountPoint = /(?<!#.*)root\s*=\s*(?<mountPoint>.*)/g.exec(configContent); | |||
There was a problem hiding this comment.
The regex results in an error: https://regex101.com/r/4pJXHS/1
There was a problem hiding this comment.
I'm not sure I see the error, has the regex101 test string changed? I just see #root and root below it which doesn't match, but that's no different to the original regex because it expects = after root. If I change the second line to root=/ it finds the match group.
I've tested this change locally with a #root comment directly above the actual mount point setting and it worked as expected.
There was a problem hiding this comment.
Ok. It turns out I was looking at it with Safari and Safari doesn't support negative lookbehind.
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mount point is detected by reading wsl.conf (PR #219), but the regex does not ignore commented lines (see #246). This PR adds a negative lookbehind for lines starting with a hash character.
Fixes #246