Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the app.argument option #237

Merged
merged 1 commit into from Mar 21, 2021
Merged

Conversation

naoki-tomita
Copy link
Contributor

@naoki-tomita naoki-tomita commented Mar 21, 2021

If you specify arguments, it will not be reflected in the spawn command.
This issue is also mentioned in fixes #234.

I add test and fix code.
It will fix this problem.

options.app has arguments property. However, programmatically, the specified property is being ignored because it is accessing appArguments.

@sindresorhus sindresorhus changed the title Bugfix🐛: Specify arguments. Fix the app.argument option Mar 21, 2021
@sindresorhus sindresorhus merged commit e127ae8 into sindresorhus:main Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v8.0.2: program arguments still not being passed to Mac's open program (previously #231)
2 participants