New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Node.js 10.17, add .apps
and allow multiple apps to be tried
#222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Richienb
commented
Feb 13, 2021
Richienb
commented
Feb 13, 2021
TrySound
reviewed
Feb 13, 2021
Not sure we even need |
sindresorhus
requested changes
Feb 17, 2021
If we only care about the last error then adding the function to |
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Richienb
commented
Feb 17, 2021
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Richienb
changed the title
Require Node.js 12, add
Require Node.js 10, add Feb 17, 2021
.apps
and allow multiple apps to be tried.apps
and allow multiple apps to be tried
Ping |
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Richienb
changed the title
Require Node.js 10, add
Require Node.js 10.17, add Feb 21, 2021
.apps
and allow multiple apps to be tried.apps
and allow multiple apps to be tried
sindresorhus
requested changes
Feb 26, 2021
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Merged
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're making a breaking change, I went ahead and bumped it up to Node.js 12. However, I'll roll it back if we're not quite ready.
Fixes: #116
IssueHunt Summary
Referenced issues
This pull request has been submitted to: