Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Node.js 10.17, add .apps and allow multiple apps to be tried #222

Merged
merged 18 commits into from Feb 28, 2021

Conversation

Richienb
Copy link
Contributor

@Richienb Richienb commented Feb 13, 2021

const open = require('open');

await open('https://google.com', {
	app: {
		name: open.apps.chrome
	}
});

Since we're making a breaking change, I went ahead and bumped it up to Node.js 12. However, I'll roll it back if we're not quite ready.

Fixes: #116


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


Signed-off-by: Richie Bendall <richiebendall@gmail.com>
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Not sure we even need AggregateError here. We only really care about the last failure.

index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
test.js Outdated Show resolved Hide resolved
@Richienb
Copy link
Contributor Author

Not sure we even need AggregateError here. We only really care about the last failure.

If we only care about the last error then adding the function to aggregate-error won't help.

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
index.js Outdated Show resolved Hide resolved
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb Richienb changed the title Require Node.js 12, add .apps and allow multiple apps to be tried Require Node.js 10, add .apps and allow multiple apps to be tried Feb 17, 2021
@Richienb
Copy link
Contributor Author

Ping

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb Richienb changed the title Require Node.js 10, add .apps and allow multiple apps to be tried Require Node.js 10.17, add .apps and allow multiple apps to be tried Feb 21, 2021
index.d.ts Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
readme.md Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@sindresorhus sindresorhus merged commit 8c00bd8 into sindresorhus:main Feb 28, 2021
index.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add app constants for popular apps
3 participants