Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PowerShell on Windows for improved reliability #188

Merged
merged 5 commits into from
Aug 21, 2020

Conversation

tim-stasse
Copy link
Contributor

Fixes #173

@sindresorhus
Copy link
Owner

Why not use wslview as proposed in #173?

@tim-stasse
Copy link
Contributor Author

I wanted to, and actually based this change on it (it uses powershell under the hood). However it doesn't support passing additional arguments to the underlying start command in powershell and therefore wouldn't allow implementing the wait/app options.

index.js Show resolved Hide resolved
@sindresorhus
Copy link
Owner

sindresorhus commented Aug 11, 2020

With this change, I guess the url option is moot? Since it was added because of & escaping problems on Windows. Maybe we should just remove that option now?

@tim-stasse
Copy link
Contributor Author

It's up to you really, that would be a breaking API change, but it—theoretically—won't actually break any existing usages if it's removed.

Let me know if you'd prefer to remove it as part of this change or not.

@sindresorhus
Copy link
Owner

We can remove it from the JS code, but it has to stay in the index.d.ts file (with a doc comment that it will be removed in the next major release).

@sindresorhus sindresorhus changed the title Use powershell as an alternative URL opener on WSL Use PowerShell on Windows for improved reliability Aug 21, 2020
@sindresorhus sindresorhus merged commit f7ca0d3 into sindresorhus:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternative URL opener on WSL - wslview
2 participants