Add allowNonzeroExitCode option
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
changed the title
allowNonzeroExitCode option
sindresorhus
requested changes
May 4, 2020
index.d.ts
Outdated
|
|
||
| /** | ||
| Use to allow non zero exit code. | ||
| the convention for success exit code was 0, But in some cases there is an app that doesn't return 0 for the success exit code. |
There was a problem hiding this comment.
Put some more effort into this text.
index.d.ts
Outdated
| Use to allow non zero exit code. | ||
| the convention for success exit code was 0, But in some cases there is an app that doesn't return 0 for the success exit code. | ||
|
|
||
| @default true |
There was a problem hiding this comment.
It should not be true by default.
index.d.ts
Outdated
| the convention for success exit code was 0, But in some cases there is an app that doesn't return 0 for the success exit code. | ||
|
|
||
| @default true | ||
| */ |
index.d.ts
Outdated
| @@ -42,6 +42,14 @@ declare namespace open { | |||
| @default false | |||
| */ | |||
| readonly url?: boolean; | |||
|
|
|||
| /** | |||
| Use to allow non zero exit code. | |||
There was a problem hiding this comment.
Suggested change
| Use to allow non zero exit code. | |
| Use to allow nonzero exit code. |
|
okay i'll try to make it better |
sindresorhus
reviewed
Jul 7, 2020
sindresorhus
reviewed
Jul 7, 2020
sindresorhus
reviewed
Jul 7, 2020
readme.md
Outdated
| Type: `boolean`\ | ||
| Default: `false` | ||
|
|
||
| Option to allow the opened app resolve the promise with nonzero exit code when `wait` option value `true`. |
There was a problem hiding this comment.
The readme docs should be in sync with the index.d.ts. The text here is different.
There was a problem hiding this comment.
so sorry i miss the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing issue using #161 as reference
Fixes #86