Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity check for non-existant files #674

Open
Richienb opened this issue Feb 13, 2023 · 1 comment
Open

Sanity check for non-existant files #674

Richienb opened this issue Feb 13, 2023 · 1 comment

Comments

@Richienb
Copy link
Contributor

Check that the files declared in the package.json are actually there before publishing.

Description

Files specified in the [main]?, types, and exports fields in the package.json should be checked for before pushing to npm.

Is the feature request related to a problem?

Both p-queue@^7.3.1 and p-queue@^7.3.2 don't contain compiled code because the build script didn't generate them and np didn't catch it.

Possible implementation

Run the check directly after the lifecycle scripts and directly before pushing to npm.

Alternatives

Manually checking is error-prone

@tommy-mitchell
Copy link
Collaborator

Related: #82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants