-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix showing files added since the last release #595
Conversation
Tests are failing. |
I created a file |
@sindresorhus
When these bullet points were all negative, the prompt shows file
|
I cannot reproduce anymore, so you're probably right that it had either of those conditions. |
const message = `The following new files are not already part of your published package:\n${chalk.reset(ignoredFiles.map(path => `- ${path}`).join('\n'))}`; | ||
const messages = []; | ||
if (newFiles.unpublished.length > 0) { | ||
messages.push(`The following new files will not be part of your published package:\n${chalk.reset(newFiles.unpublished.map(path => `- ${path}`).join('\n'))}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this message is inaccurate? Maybe it should read:
The following new files are not already part of your published package
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jessieay I agree! This is a very confusing message! Happens on files which have no apparent reason not to be included!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok great seems to be fixed in new version. Thanks!
Add support for unpublished as well as first time published files as mention in #588 (comment).