Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --release-draft-only flag #594

Merged
merged 5 commits into from Feb 7, 2021

Conversation

Drarig29
Copy link
Contributor

Fixes #593

Here is the result with the repo GhostText :

$ gh repo clone GhostText/GhostText
$ git checkout 17.12.11.910
$ np --release-draft-only

Create a release draft on GitHub for GhostText-browser (current: 0.0.0)

Commits:
- Fix: highlight text field when the connection happens, not when the field is focused  d88c3f7
- Feature: Automatically skip invisible textareas  b35eae9
- Fix: Remove unsupported blur event from CodeMirror  3cacd7d
- Refactor: Drop google-specific contenteditable  88f55ca
- Feature: support more contenteditable elements across the page  873f7c3
- Add HTML page for tests  e3df6ce
- Revert "Disable extensions-only deployment condition"  5726259
- Readme: improve usage  c07e2c8
- Readme: formatting/wording improvements  df91d5e
- Disable extensions-only deployment condition  30cac4f
- Update license  a05af1a
- Disable keyboard shortcut in Firefox (#121)  d5822b6
- Readme: added contribution plea  9d8d3d1
- Readme: added plugin for neovim (#115)  eb90e0c
- Readme: add link to Acme client (#108)  5380d8a

Commit Range:
17.10.25.1400...17.12.11.910

Registry:
https://registry.npmjs.org/



✖ You need to specify either the `repoUrl` option or both the `user` and `repo` options

The remaining problems are not related to the --release-draft-only flag.

source/git-util.js Outdated Show resolved Hide resolved
source/git-util.js Show resolved Hide resolved
source/git-util.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Tests are failing.

@sindresorhus
Copy link
Owner

Re #594 (comment) Sorry, I'm dumb. I missed the - 1 part. .indexOf was indeed the best solution.

@Drarig29
Copy link
Contributor Author

Drarig29 commented Feb 1, 2021

Re #594 (comment) Sorry, I'm dumb. I missed the - 1 part. .indexOf was indeed the best solution.

Lol, no problem 😉

source/git-util.js Outdated Show resolved Hide resolved
source/git-util.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

np --release-draft-only has several issues (wrong tag, "missing repoURL" error)
2 participants