New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if yarn.lock is ignored before throwing error #582
Conversation
@sindresorhus , we did have a CI and few other checks right? Looks like the Travis CI is broken and not building for PRs. |
Travis stopped giving open source free access, so I have to move all my repos to GitHub Actions... Tests seem to be stalling there though and I'm not sure why: https://github.com/sindresorhus/np/runs/1452129350 |
https://github.com/sindresorhus/np/runs/1452129338 - Looks like this run was aborted now with signal 137 which was probably due to us using excessive memory. I checked out the tests and looks like they are all running fine. Could it be something with the new integration tests we introduced?
I can see this being printed in https://github.com/sindresorhus/np/runs/1452129365. Looks like it is the integration tests which are causing the problems. |
// @bunysae |
I have 1000+ repos to update... |
@sindresorhus you can apply for an open-source grant from them. I am pretty sure that they will happily grant more build time for you. |
@gautamkrishnar I asked and you have to apply per repo and include arguments and stuff, which is just totally unfeasible for me. I also don't foresee Travis existing in a couple of years. |
@sindresorhus oh! that's bad. |
I'd be happy to help if you have any ideas where we are going to start from. |
@dopecodez That's nice of you to offer. It's basically about doing exactly what's done in this commit: 6b410d7 Add that exact GH Actions file and remove Travis file and badge. Could maybe be scripted. |
🤔 |
Fixes #573.
Checks if
yarn.lock
is gitignored before throwingyarn.lock file is outdated. Run yarn, commit the updated lockfile and try again.