Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if yarn.lock is ignored before throwing error #582

Merged
merged 7 commits into from Dec 31, 2020
Merged

Check if yarn.lock is ignored before throwing error #582

merged 7 commits into from Dec 31, 2020

Conversation

dopecodez
Copy link
Collaborator

Fixes #573.

Checks if yarn.lock is gitignored before throwing yarn.lock file is outdated. Run yarn, commit the updated lockfile and try again.

@dopecodez dopecodez changed the title added logic to check if yarn.lock is ignored before throwing error Checks if yarn.lock is ignored before throwing error Nov 24, 2020
@dopecodez
Copy link
Collaborator Author

@sindresorhus , we did have a CI and few other checks right? Looks like the Travis CI is broken and not building for PRs.

@sindresorhus
Copy link
Owner

Travis stopped giving open source free access, so I have to move all my repos to GitHub Actions...

Tests seem to be stalling there though and I'm not sure why: https://github.com/sindresorhus/np/runs/1452129350

@dopecodez
Copy link
Collaborator Author

dopecodez commented Nov 25, 2020

https://github.com/sindresorhus/np/runs/1452129338 - Looks like this run was aborted now with signal 137 which was probably due to us using excessive memory. I checked out the tests and looks like they are all running fine. Could it be something with the new integration tests we introduced?

✖ ../test/integration.js exited due to SIGABRT␊

I can see this being printed in https://github.com/sindresorhus/np/runs/1452129365. Looks like it is the integration tests which are causing the problems.
Anyways, Travis CI stopping free open source is going to lead to a enormous amount of backlog in the open source community undoubtedly.

@sindresorhus
Copy link
Owner

// @bunysae

@sindresorhus
Copy link
Owner

Anyways, Travis CI stopping free open source is going to lead to a enormous amount of backlog in the open source community undoubtedly.

I have 1000+ repos to update...

@gautamkrishnar
Copy link

@sindresorhus you can apply for an open-source grant from them. I am pretty sure that they will happily grant more build time for you.

@sindresorhus
Copy link
Owner

@gautamkrishnar I asked and you have to apply per repo and include arguments and stuff, which is just totally unfeasible for me. I also don't foresee Travis existing in a couple of years.

@gautamkrishnar
Copy link

@sindresorhus oh! that's bad.

@dopecodez
Copy link
Collaborator Author

I have 1000+ repos to update...

I'd be happy to help if you have any ideas where we are going to start from.

@sindresorhus
Copy link
Owner

@dopecodez That's nice of you to offer. It's basically about doing exactly what's done in this commit: 6b410d7 Add that exact GH Actions file and remove Travis file and badge. Could maybe be scripted.

source/index.js Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title Checks if yarn.lock is ignored before throwing error Check if yarn.lock is ignored before throwing error Dec 21, 2020
@sindresorhus sindresorhus merged commit c76987a into sindresorhus:master Dec 31, 2020
@Richienb
Copy link
Contributor

Could maybe be scripted.

🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tailor yarn.lock error based on whether it is gitignored
4 participants