New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make commit log relative to release branch #580
Conversation
We need to pick Line 58 in c43c6cf
|
For some reason running |
Can you fix the merge conflict? |
8c56ef8
to
a7e3400
Compare
Done! I'm still concerned about this though. |
The current code crashes when you run |
The changes look good now, the error was being caused by a wrong import. I tried out the functionality as well and it looks it is working relative to release branch. |
summary
np
provides a mechanism for specifying a release branch other thanmaster
. Notablymain
is a popular one. Am I correct in thinking that the current "Commit Log" generated will always be relative to master regardless of release branch?Please let me know if I'm misunderstanding anything.
If this fix generally looks good, I'd be happy to add tests.