Allow explicit private publish to prevent public publish prompt

[kylemh]

Fixes #496

This will enable private, Org-scoped packages to easily publish new versions of a package as part of a CI/CD process by preventing the prompt of publically publishing a package when publishConfig.access is explicitly set to 'restricted' in package.json.

Also "booleanified" runPublish -> shouldRunPublish and reduced the number of times the same boolean is re-defined.

[chinesedfan]

I don't know whether setting publishConfig.access will prevent the prompt or not. So will keep silent for it and hope we can handle every prompt friendly in future.

About runPublish,

• Glad to see replacing options.publish && !pkg.private with runPublish as I commented.
• But would not like extract it as shouldRunPublish. The name is not consistent with runTests, runCleanup. Considering we have no sufficient tests and the redundant logic is short, I prefer the conservative way.

[itaisteinherz]

LGTM 👍🏻 Thanks for working on this @kylemh!

[itaisteinherz]

@chinesedfan Have you tested this locally and can verify this works for you? (I haven't tested this out myself, but will hopefully get to it sometime in the next few days.)

[chinesedfan]

@itaisteinherz I didn't have an end-to-end package to test. Here are how I tested,

• Add some fields in package.json of np

	"private": true,
	"publishConfig": {
		"access": "restricted"
	},

• Run, node source/cli.js and select the version
• I saw it entered prerequisite-tasks stage(i.e. Git -> Check current branch) without any other prompts.

[kylemh]

FWIW, I exported my own fork of this PR and am using it in a repository already. I know y'all ensure everything's perfect with PRs, but I needed it immediately 😂

[itaisteinherz]

Merging as this is ready IMO. Thanks again for working on this @kylemh 🙏🏻

[kylemh]

Thanks! @itaisteinherz

FWIW, I'm a little afraid of the wording with private just because I went down a rabbit hole of adding private: true which actually prevents publishes entirely

[itaisteinherz]

FWIW, I'm a little afraid of the wording with private just because I went down a rabbit hole of adding private: true which actually prevents publishes entirely

I agree it's a bit confusing, but it's also the terminology npm uses. In this case, I think adding a note to the readme would help avoid any confusion. If you're up for doing that and creating another PR, that would be great 😉