Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stripWWW logic #117

Merged
merged 3 commits into from Aug 2, 2020
Merged

Improve stripWWW logic #117

merged 3 commits into from Aug 2, 2020

Conversation

gcox
Copy link
Contributor

@gcox gcox commented Jul 31, 2020

Fixes #116

@gcox
Improves stripWWW related regex ...
9119803 
* Supports TLDs up to 63 characters like other DNS labels. There are existing TLDs that are at least 25 characters long.
* Supports single character domains
* Supports internationalized TLDs (requires allowing for "-" and numeric characters in the TLD): https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains#Internationalized_country_code_top-level_domains
sindresorhus
sindresorhus reviewed Aug 2, 2020
View reviewed changes
test.js Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title Improves stripWWW related regex Improve stripWWW feature Aug 2, 2020
@sindresorhus sindresorhus changed the title Improve stripWWW feature Improve stripWWW logic Aug 2, 2020
@sindresorhus sindresorhus merged commit 0ee9d94 into sindresorhus:master Aug 2, 2020
@sindresorhus
Copy link
Owner

Thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strip WWW doesn't work on some domains
2 participants
@gcox @sindresorhus