Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure with isMultiple when isRequired function returns false #194

Merged
merged 1 commit into from Jul 29, 2021
Merged

Fix failure with isMultiple when isRequired function returns false #194

merged 1 commit into from Jul 29, 2021

Conversation

softwarewright
Copy link
Contributor

@softwarewright softwarewright commented Jul 21, 2021 •
edited by sindresorhus

Fixes #193

@softwarewright softwarewright mentioned this pull request Jul 21, 2021
Closed
@sindresorhus
Copy link
Owner

Thanks for the pull request. Always ensure running npm test locally passes before pushing commits.

@softwarewright
Copy link
Contributor Author

@sindresorhus Ah sorry assumed it was a local issue. I'll look at why the build is failing.

@softwarewright
Copy link
Contributor Author

@sindresorhus I fixed the lint errors, the other typescript issue seems to be with the xo package, but I think you are already aware of this: xojs/xo#555.

@sindresorhus sindresorhus changed the title Fix failure with isMultiple when isRequired func returns false Fix failure with isMultiple when isRequired function returns false Jul 29, 2021
@sindresorhus sindresorhus merged commit e1f0e24 into sindresorhus:main Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isMultiple is still required when isRequired fn returns false
2 participants
@softwarewright @sindresorhus