Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow default property of Flag types to accept arrays #190

Merged
merged 3 commits into from Jul 15, 2021
Merged

Allow default property of Flag types to accept arrays #190

merged 3 commits into from Jul 15, 2021

Conversation

RobertSasak
Copy link
Contributor

Fixes: #189

@sindresorhus
Copy link
Owner

Can you add a type test?

And when isMultiple: true, it should only be an array.

@RobertSasak
Copy link
Contributor Author

Thank you for teaching me tsd

@sindresorhus sindresorhus changed the title Allow "default" property of Flag accepts arrays Allow default property of Flag types to accept arrays Jul 15, 2021
@sindresorhus sindresorhus merged commit ae73466 into sindresorhus:main Jul 15, 2021
@sindresorhus
Copy link
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript definition for default does not support arrays
2 participants
@RobertSasak @sindresorhus