Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Node.js 12 and move to ESM #181

Merged
merged 11 commits into from Apr 27, 2021
Merged

Conversation

LitoMore
Copy link
Sponsor Contributor

@LitoMore LitoMore commented Apr 25, 2021

Fixes #125
Resolves #157
Resolves #176

@LitoMore
Copy link
Sponsor Contributor Author

LitoMore commented Apr 25, 2021

@sindresorhus Do I need to apply this proposal #157 (comment) in current PR?

@sindresorhus
Copy link
Owner

Do I need to apply this proposal #157 (comment) in current PR?

It doesn't have to be this PR, but it has to be done before what's in this PR can be released.

@sindresorhus
Copy link
Owner

sindresorhus commented Apr 25, 2021

The TS types are not correctly done. You need to remove the use of namespace and export the individual types.

index.d.ts Outdated Show resolved Hide resolved
test/is-required-flag.js Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Please read #181 (comment) more closely.

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@sindresorhus sindresorhus merged commit 05320ac into sindresorhus:main Apr 27, 2021
@sindresorhus
Copy link
Owner

Looks good :)

@LitoMore LitoMore deleted the esm branch April 28, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants