Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default isMultiple to empty array #163

Merged
merged 6 commits into from Oct 19, 2020

Conversation

ulken
Copy link
Contributor

@ulken ulken commented Oct 1, 2020

Note: Changes behavior for booleanDefault: undefined as well. With this change in place, I don't think it makes sense to filter out unset boolean array flags any longer.

Fixes #161

@sindresorhus
Copy link
Owner

Changes behavior for booleanDefault: undefined as well.

I think the behavior should be made clear in the readme & index.d.ts.

@ulken
Copy link
Contributor Author

ulken commented Oct 19, 2020

@sindresorhus Gave it a go.

While I was at it, I took the liberty to

  1. Change the structure to adhere to the rest of the README, i.e. break it into two paragraphs. First a sentence to describe what the flag does, followed by a more detailed description of its ins and outs.
  2. Synced README and index.d.ts in terms of content (one line was missing from the README).

If you disapprove, let me know and I'll revert.

@sindresorhus sindresorhus merged commit 14924de into sindresorhus:master Oct 19, 2020
@sindresorhus
Copy link
Owner

Looks good 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isMultiple should result in an empty array when the flag is not specified
2 participants