Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically release memory when an item expires - fixes #14 #19

Merged
merged 1 commit into from Aug 27, 2018

Conversation

SamVerschueren
Copy link
Collaborator

This PR fixes #14 by using map-age-cleaner which removes item when it expires.

@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

@SamVerschueren
Copy link
Collaborator Author

Done

@sindresorhus sindresorhus merged commit da4e439 into master Aug 27, 2018
@sindresorhus sindresorhus deleted the iss14 branch August 27, 2018 17:27
@mbrookes
Copy link

mbrookes commented Oct 8, 2018

Any possibility if backporting this to 3.0? yargs/yargs#1223 Thanks!

kittaakos pushed a commit to eclipse-theia/theia that referenced this pull request Jul 8, 2019
See: sindresorhus/memoize/pull/19.
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak: old results are not deleted from the cache
3 participants