Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be prefixUrl prepended if input is a URL instance? #152

Closed
szmarczak opened this issue Jul 14, 2019 · 2 comments
Closed

Should be prefixUrl prepended if input is a URL instance? #152

szmarczak opened this issue Jul 14, 2019 · 2 comments
Labels
question Further information is requested

Comments

@szmarczak
Copy link
Collaborator

See sindresorhus/got#829 (review)
@szmarczak szmarczak added the question Further information is requested label Jul 14, 2019
@sholladay
Copy link
Collaborator

Absolute URLs, that is. URL instances happen to always be absolute, at time of writing (hopefully they will support relative URLs in the future)..

@szmarczak
Copy link
Collaborator Author

I think it should be prepended. It can be easily turned off by using prefixUrl: ''.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sholladay @szmarczak