Various fixes #13
Merged
Various fixes #13
+105
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Match single-character organisation or repository name - Don't match organisation or repository name that are too long - Don't match issue numbers greater than 10^100-1 - Put organisation name, repository name and issue number into capturing groups 1, 2 and 3. - Add missing Prettier configuration Fixes sindresorhus#9, sindresorhus#10, sindresorhus#11, sindresorhus#12
Closed
|
Perhaps we shouldn't merge this until we've decided what to do with #15. If that gets implemented, the capturing groups might change and necessitate a release with breaking changes. Probably better to sort this all out in one go. |
|
On second thought, why don't we merge this and then address #15 in a separate PR, and wait with a release until after that? |
👍 |
|
Vaguely, but perhaps you should go ahead with a release if that's what you're asking? |
sindresorhus
added a commit
that referenced
this pull request
Jun 11, 2022
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9, Fixes #10, Fixes #11, Fixes #12, Fixes #14