Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false-negative with linebreaks inside the SVG tag #29

Merged
merged 1 commit into from Nov 24, 2021

Conversation

StephanHoyer
Copy link
Contributor

@StephanHoyer StephanHoyer commented Nov 19, 2021

Fixes #28

width="75"
height="75"
version="1.1"
></svg>`));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test passes on the main branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried it again, does not work for me. I also tried it on runkit, still does not work.

https://runkit.com/embed/r74bv6am4lp6

@sindresorhus sindresorhus changed the title Fix false negative with linebreaks inside the svg tag - fixes #28 Fix false-negative with linebreaks inside the SVG tag Nov 24, 2021
@sindresorhus sindresorhus merged commit d46292d into sindresorhus:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False negativ
2 participants