Require Node.js 10 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sindresorhus Could you take a look at this one? 🙏 It's currently the 3rd biggest dependent of |
sindresorhus
requested changes
Nov 14, 2020
index.js
Outdated
| if (!input) { | ||
| return Promise.resolve(0); | ||
| } | ||
|
|
||
| return pify(zlib.gzip)(input, getOptions(options)).then(data => data.length).catch(_ => 0); | ||
| const data = await promisify(zlib.gzip)(input, getOptions(options)); |
There was a problem hiding this comment.
It's generally better to do the promisification at the top-level if it doesn't require any local state, so it doesn't have to be done for each function invocation.
|
|
||
| module.exports = (input, options) => { | ||
| module.exports = async (input, options) => { | ||
| if (!input) { | ||
| return Promise.resolve(0); | ||
| } | ||
|
|
There was a problem hiding this comment.
The Promise.resolve is moot now.
package.json
Outdated
| "ava": "^2.4.0", | ||
| "p-event": "^4.2.0", | ||
| "tsd": "^0.13.1", | ||
| "typescript": "^4.0.5", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This nicely gets rid of the dependency of
pify.