From 7c8be66a304191daa1f3ef9b6cefc6fb371a6838 Mon Sep 17 00:00:00 2001 From: Nathan Duthoit Date: Fri, 18 Nov 2022 08:04:47 -0500 Subject: [PATCH] fix: destroy request object after successful response --- source/as-promise/index.ts | 1 + test/promise.ts | 11 +++++++++++ 2 files changed, 12 insertions(+) diff --git a/source/as-promise/index.ts b/source/as-promise/index.ts index 8f3698ede..2970798a9 100644 --- a/source/as-promise/index.ts +++ b/source/as-promise/index.ts @@ -131,6 +131,7 @@ export default function asPromise(normalizedOptions: NormalizedOptions): Canc return; } + request.destroy(); resolve(request.options.resolveBodyOnly ? response.body as T : response as unknown as T); }); diff --git a/test/promise.ts b/test/promise.ts index 3e01601c6..63e64e26e 100644 --- a/test/promise.ts +++ b/test/promise.ts @@ -95,3 +95,14 @@ test('promise.json() does not fail when server returns an error and throwHttpErr const promise = got('', {throwHttpErrors: false}); await t.notThrowsAsync(promise.json()); }); + +test('the request is destroyed once the promise has resolved', withServer, async (t, server, got) => { + server.get('/', (_request, response) => { + response.statusCode = 200; + response.end('null'); + }); + + const {request} = await got(''); + + t.true(request.destroyed); +});