Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance socket timeout description #2055

Merged
merged 2 commits into from Jun 10, 2022
Merged

Enhance socket timeout description #2055

merged 2 commits into from Jun 10, 2022

Conversation

Rychu-Pawel
Copy link
Contributor

@Rychu-Pawel Rychu-Pawel commented Jun 7, 2022 •
edited

According to the discussion in #2049 I believe the description of socket timeout might be enhanced a bit.

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates in both the README and the types.

@Rychu-Pawel
Enhance socket timeout description
35be01d 
According to the discussion in #2049 I believe the description of socket timeout might be enhanced a bit.
@szmarczak szmarczak merged commit 5c628cc into sindresorhus:main Jun 10, 2022
@szmarczak
Copy link
Collaborator

Thanks!

@Rychu-Pawel Rychu-Pawel deleted the patch-1 branch June 10, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szmarczak szmarczak szmarczak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rychu-Pawel @szmarczak