Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deflate responses not being decompressed #1918

Merged
merged 1 commit into from Dec 10, 2021

Conversation

iOnline247
Copy link
Contributor

@iOnline247 iOnline247 commented Nov 13, 2021

I think this should be deflate.

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates in both the README and the types.

I think this should be deflate.
@szmarczak
Copy link
Collaborator

Thanks, this is an important fix! Can you add a test please?

@szmarczak szmarczak changed the title Typo fix Fix `deflate| Nov 13, 2021
@szmarczak szmarczak changed the title Fix `deflate| Fix deflate responses not being decompressed Nov 13, 2021
@iOnline247
Copy link
Contributor Author

Admittedly, I'm new to the code base. Was just reading through and noticed an odd magic string. Is there an example test that would be a good boilerplate to follow? I'm guessing this one would be a good starting point.

https://github.com/sindresorhus/got/blob/main/test/promise.ts#L33-L41

@dynamiclover
Copy link

This should be merged as a fix.

Reasoning:
There's no test coverage currently for deflate or it would have caught the typo.

The CI failures seem spurious/unrelated to this change.

@sindresorhus sindresorhus merged commit ecb0534 into sindresorhus:main Dec 10, 2021
@iOnline247 iOnline247 deleted the patch-1 branch January 4, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants