Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed options.port on redirect #1439

Merged
merged 3 commits into from Sep 5, 2020
Merged

Fixed options.port on redirect #1439

merged 3 commits into from Sep 5, 2020

Conversation

Giotino
Copy link
Collaborator

@Giotino Giotino commented Sep 5, 2020 •
edited

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates in both the README and the types.

Fixes #1437

@Giotino Giotino changed the title Fixed port on redirect Fixed options.port on redirect Sep 5, 2020
@Giotino Giotino marked this pull request as ready for review September 5, 2020 09:41
@szmarczak szmarczak merged commit 408e22a into sindresorhus:master Sep 5, 2020
@szmarczak
Copy link
Collaborator

Thanks a lot! 🙌

@Giotino Giotino deleted the issue-1437 branch September 6, 2020 09:48
@sindresorhus
Copy link
Owner

@Giotino Would you be interested in joining Got as a maintainer? You've done a lot of good PRs. 🙌🏻

@Giotino
Copy link
Collaborator Author

Giotino commented Sep 6, 2020

Sure, it would be a pleasure to work with you to improve this repo.

@sindresorhus
Copy link
Owner

@Giotino Awesome. Welcome to the team!

We usually do pull requests for most changes as it's always good to get a second eye on changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't override port on redirect
3 participants
@Giotino @szmarczak @sindresorhus