Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promise.json() throws when options haven't been normalized yet #1438

Closed
2 tasks done
szmarczak opened this issue Sep 4, 2020 · 1 comment
Closed
2 tasks done

promise.json() throws when options haven't been normalized yet #1438

szmarczak opened this issue Sep 4, 2020 · 1 comment
Assignees
@szmarczak
Labels
bug Something does not work as it should regression Something does not work anymore
Milestone
Got v11.7.0

Comments

@szmarczak
Copy link
Collaborator

Describe the bug

  • Node.js version: all
  • OS & version: all

The faulty part: v11.5.2...v11.6.0#diff-6be2971b2bb8dbf48d15ff680dd898b0R191

Actual behavior

Cannot destructure property 'headers' of 'globalRequest.options' as it is undefined

Expected behavior

No error.

Code to reproduce

See fregante/chrome-webstore-upload#41

Checklist

  • I have read the documentation.
  • I have tried my code with the latest version of Node.js and Got.
@szmarczak szmarczak added bug Something does not work as it should regression Something does not work anymore labels Sep 4, 2020
@szmarczak szmarczak self-assigned this Sep 4, 2020
@fregante fregante mentioned this issue Sep 4, 2020
Closed
@szmarczak szmarczak added this to the Got v11.7.0 milestone Sep 17, 2020
@szmarczak
Copy link
Collaborator Author

Fixed in c97ce7c

szmarczak added a commit that referenced this issue Sep 20, 2020
@szmarczak
Add a test for #1438 (#1469)
c31366b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szmarczak szmarczak

Labels
bug Something does not work as it should regression Something does not work anymore
Projects
None yet
Milestone
Got v11.7.0
Development

No branches or pull requests
1 participant
@szmarczak