Don't allocate buffer twice

[xamgore]

• getBuffer returns a buffer of concatenated response chunks.
• Its result is stored in rawBody and passed to parseBody.
• Then it meets Buffer.from(rawBody) and triggers a new buffer allocation:
  https://nodejs.org/api/buffer.html#buffer_class_method_buffer_from_buffer

Now a new Buffer created without copying the underlying memory.
https://nodejs.org/api/buffer.html#buffer_class_method_buffer_from_arraybuffer_byteoffset_length

Checklist

• I have read the documentation.
• I have included a pull request description of my changes.
• I have included some tests.
• If it's a new feature, I have included documentation updates.

[sindresorhus]

Tests are failing.

[xamgore]

Yeah, I know. Just need time to get familiar with the project and tests.

[szmarczak]

parseBody copies the body so even if you modify the buffer then promise.text() will give the original body.

[szmarczak]

@sindresorhus Although we could add an environment variable to disable this.

		if (responseType === 'buffer') {
			return process.env.GOT_MUTABLE_BODY ? rawBody : Buffer.from(rawBody);
		}

or should we just return the original buffer? If so, then this could happen:

const promise = got('https://somesitehere.com'); //=> 123
const buffer = await promise.buffer();
buffer.write(49, 0);

const text = await promise.text(); //=> 223, not 123!

or we could warn users in the docs... If we decide to return the original buffer then it will use 2x less RAM for people who do got().buffer().

[sindresorhus]

or should we just return the original buffer? If so, then this could happen:

That seems extremely unlikely though. Why would they write to a buffer they got from a method call. But maybe we could just override the .write() method and throw an error if used?

---

Also, upvote and comment on this issue: nodejs/node#27080

[sindresorhus]

But maybe we could just override the .write() method and throw an error if used?

@szmarczak Thoughts on this?

[szmarczak]

Thoughts on this?

That wouldn't work as you'd still be able to do buffer[0] = 123; since it's also Uint8Array...

[sindresorhus]

We could Object.freeze it?

[szmarczak]

TypeError: Cannot freeze array buffer views with elements

[sindresorhus]

[sindresorhus]

@szmarczak Maybe we could at least wrap the TS type in Readonly so at least TS users are protected?