Fix hanging promise on aborted requests on Node v14.3.0 #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to remove this if Line 1492 in 2c8fe19 if (this.destroyed) { return; } at the beginning of _beforeError.
|
|
^ just to prevent calling before error hooks if the error is not emitted. |
|
Like this?601fe10 |
szmarczak
approved these changes
May 31, 2020
szmarczak
changed the title
szmarczak
pushed a commit
to jaulz/got
that referenced
this pull request
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this is a solution that "works", but to me it doesn't seems right.
Fixes #1295